Fix script to run examples locally #285
Conversation
Ignore comment lines and empty lines in the example lists file. Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
There was a problem hiding this comment.
Thank you for updating the script!
There is a minor mess with those test scripts as they are all kind of duplicated:
The workflow file differs a bit from the first two scripts but does basically the same (besides also comparing the results with the master branch).
However we can think of removing the run-validation.sh script since run-examples.sh is more sophisticated.
|
Yes, it would be good to unify the script to reduce code maintenance and use this then in the GitHub workflow as well. I will check and come back with an update for this PR. |
- Added command line options - Add one second timeout at end of test to easy interruption - Updated default run parameters to match run-validation script Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
|
Improved the run-example script so it can be reused in the run-validation script. The github workflow requires more logic than this simple local executor script as it checks for matching outputs from different branches. So I will not address this with this PR and I consider this to be ready for merging. |
Co-authored-by: FG-TUM <FG-TUM@users.noreply.github.com>
Co-authored-by: FG-TUM <FG-TUM@users.noreply.github.com>
Co-authored-by: HomesGH <55833544+HomesGH@users.noreply.github.com>
Co-authored-by: FG-TUM <FG-TUM@users.noreply.github.com>
Fix parameter expansion so option values are kept correctly. This fixes issues handling multi-value option arguments, e.g., allowing now > ./run-examples.sh --mpi_args "-n 2 --oversubscribe 2 ..." Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
cniethammer
force-pushed
the
fix_local_example_run_script
branch
from
f257e22 to
b53855f
Compare
Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
3 participants
Fixes problems reported in #284 for the
examples/run-examples.shscript and makes it work again.