Open
Conversation
Modified VirtualMachineEntity.cs to now delete a virtual machine entity if it is determined to be not eligible for scheduling. This change ensures that our system is not keeping unnecessary data, hence improving efficiency and resource usage.
Qodana for .NET5 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Added a new method for deallocating Azure virtual machines in AzureComputeService.cs and IAzureComputeService.cs for efficient resource management. This commits allows the user to deallocate a virtual machine when it is no longer needed, helping to manage Azure resource usage more efficiently.
This commit introduces a method to start the Azure virtual machine asynchronously. The method 'StartAzureVirtualMachineAsync' was added in both the IAzureComputeService interface and the AzureComputeService class. This enhancement was needed to provide support for starting VMs without blocking the main application thread.
In the AzureComputeService.cs file, comments were added to detailedly explain the role and interactions of the different functions in managing Azure Virtual Machines. These comments elucidate how each function works and what parameters they require, which will improve code understanding and ease of use for developers.
Added functionality for recognizing specific Azure Chronos tags and validating if they are present in the virtual machine. The tags we are looking for are "AzChronos_Exclude", "AzChronos_Deallocate", and "AzChronosStartup". These tags will be used to determine if a VM is eligible for scheduling. Further, code to retrieve and process schedule from the VM's tags was implemented and a new model 'AzureChronosSchedule' was added to contain this schedule information. Also, a redundant method remark and example in AzureComputeService.cs has been removed to improve code readability. This modification allows us to have a clearer understanding of the state and scheduling of each VM and presents a way to govern VM scheduling directly through the VM's tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the following features:
GitHub Issues: