Open
Conversation
our rabbitmq consul setup likes to set the ServiceAddress to be its own node name, which is the internal dns record. this breaks the expectations of cloud map, which wants IP addresses we can use Node.Address here instead which will be the IP address of the node, and therefore the service address too (we don't have multiple network interfaces for our nodes) this also changes the service instance ID to the node name, which we know is unique and is easier to identify
by default, consul-aws only creates 1:1 services with those registered in consul, but we leverage tags to distinguish between difference kinds of service instances (e.g. primary and replica database nodes) this change takes tags into account when creating the list of services, resulting in one service per tag+service combination
frangz
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.