fix: direnv not loading in Hermit environments #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename direnv/path.zsh to direnv/direnv.zsh so it loads in all environments. Previously, direnv hook was in path.zsh which is only loaded when HERMIT_ENV is not set. This caused direnv to not work in Hermit environments. Also fix shebang to use zsh instead of bash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
direnv/path.zshtodirenv/direnv.zshso it loads in all environmentsProblem
Previously,
direnv/path.zshwas only loaded whenHERMIT_ENVwas not set (see zsh/main.zsh:17-26). This caused direnv to not work in Hermit environments because the hook was never being loaded.Solution
Renamed to
direnv/direnv.zshso it loads with the other config files regardless of Hermit environment status.Test plan
exec zsh