fix: escape dollar sign in SSH Match exec directive #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
lox
force-pushed
the
fix-ssh-match-exec-escaping
branch
from
bc7488b to
1bc283a
Compare
Check SSH_CONNECTION instead of SSH_AUTH_SOCK to determine if we're in an SSH session. This handles the case where SSH_AUTH_SOCK is set to a system agent that doesn't have the needed keys. Logic: - SSH_CONNECTION empty (local machine) → Use 1Password IdentityAgent - SSH_CONNECTION set (SSH session) → Skip IdentityAgent, use forwarded agent Match host * exec "sh -c 'test -z \"$SSH_CONNECTION\"'" IdentityAgent "~/Library/Group Containers/2BUA8C4S2C.com.1password/t/agent.sock" This ensures: - Local sessions always use 1Password - ssh -A properly uses forwarded agent - GUI apps use 1Password
lox
force-pushed
the
fix-ssh-match-exec-escaping
branch
from
1bc283a to
2c04d6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Check
SSH_CONNECTIONinstead ofSSH_AUTH_SOCKto detect SSH sessionsProblem
The Match exec directive had quote parsing errors, and checking
SSH_AUTH_SOCKdoesn't work because macOS sets it to a default agent that lacks the necessary keys.Solution
Use
SSH_CONNECTIONto detect if we're in an SSH session:Logic:
SSH_CONNECTIONis empty → Local machine → Use 1PasswordSSH_CONNECTIONis set → In SSH session → Skip 1Password, use forwarded agentBehavior
ssh -A(forwarded)Fixes #51