Add module unregistration to buswatch-sdk #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Instrumentor::unregister(name) method to remove modules - Add GlobalState::unregister_module(name) for cleanup - Returns true if module was found and removed, false otherwise - Comprehensive tests covering: - Unregister existing module - Unregister non-existent module - Verify metrics are removed after unregister - Verify re-registering works after unregister - Old handles still work but don't appear in snapshots - Unregistering one module doesn't affect others - Multiple unregister calls are safe - Update README.md with unregistration documentation - Update CHANGELOG.md This enables clean lifecycle management for temporary or dynamic modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
Summary
Adds module unregistration functionality to buswatch-sdk, enabling clean lifecycle management for temporary or dynamic modules.
Changes
Instrumentor::unregister(name)method to remove modules from internal stateGlobalState::unregister_module(name)for module cleanuptrueif module was found and removed,falseotherwiseTests
Added comprehensive test coverage:
All 54 tests pass successfully.
Use Cases