Feat/add double opt in by lowbits · Pull Request #6 · lowbits/nuxt-hub-landing

lowbits · 2024-11-21T16:25:25Z

No description provided.

cloudflare-workers-and-pages · 2024-11-21T16:32:13Z

Deploying nuxt-hub-landing with Cloudflare Pages

Latest commit:	`d35e096`
Status:	✅ Deploy successful!
Preview URL:	https://baeab745.nuxt-hub-landing.pages.dev
Branch Preview URL:	https://feat-add-double-opt-in.nuxt-hub-landing.pages.dev

View logs

what-the-diff · 2024-11-22T07:51:05Z

PR Summary

Environment Variables Template Created: Added an example file for environment variables the application might need. This will help new developers set up faster.
README Document Update: Enhanced and detailed instructions are now available for setting up email verification with all necessary configuration details.
Application Template Cleanup: Removed deprecated waitlist code from our main application template and improved the footer layout for better readability.
Email Verification Component: Created a new component for sending verification emails to users. This ensures email standardization across the application.
Email Verification Module Addition: Included a Nuxt module that handles email verification settings, enhancing security, and user authentication.
User Sign-Up Flow Enhancement: Integrated a user sign-up handler for collecting user details and sending verification emails instantly.
Email Verification Endpoint: Established an endpoint to validate user email addresses using tokens, improving user data accuracy and security.
Updated Configuration: Updated our main application configuration to properly interact with the new email verification module.
New Dependencies Added: Integrated new libraries for email rendering in Vue and secrets generation.
Rate Limit Update: Increased the limit on joining the waitlist to help in handling more incoming traffic.
Waitlist Landing Page Addition: Developed a new landing page with an input form, which validates and processes emails for the waitlist effectively.
Email Verification Page Addition: Created a new page for processing email verification, giving a clear message on successful or failed verification.
Secret Key Generation Script: Implemented a script to automatically generate the required secret key if it's absent, improving convenience and security.
Database Update: A new column verified_at is added to the waitlist table, noting when a user email is verified.
Schema Update: Updated our database schema to include the new verified_at field, reflecting database changes in code.
Migration Metadata Update: Modified JSON metadata to record changes in database migration.
Project Configuration Update: Expanded the TypeScript configuration for including custom type definitions.
New Type Definition: Added custom types for extending runtime configurations, ensuring code maintains type safety.
Utility Functions Addition: Implemented additional helper functions for secure token creation, comparison, and verification URL generation, enhancing application security and code reusability.

elbbo · 2024-11-27T18:03:46Z

modules/nuxtHubLanding/runtime/join-waitlist.post.ts

+    const config = useRuntimeConfig()
+
+
+    if (config.landing.verifyEmail) {


config.landing is possibly undefined. Would consider to use optional chaining

elbbo · 2024-11-27T18:05:02Z

modules/nuxtHubLanding/runtime/join-waitlist.post.ts

+            subject: `Confirm your email on ${appName}`,
+            html: await render(VerifyTemplate, {
+                email: entry.email,
+                appName,


appName could be undefined, but expected type is string

Eddy401

I have finished my first iteration of review. Due to time constraints I have to split the effort. I will continue providing as soon as possible. So far I could join the waitlist, but I did not receive a email from resend (probably configuration issue).

One thing I noticed when starting the app is that the database migration is run every time and I get error about already existing tables. Here is the stackstrace:

` ERROR Database migrations failed D1_ERROR: table waitlist already exists at offset 13: SQLITE_ERROR

at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async SQLiteD1Session.batch (node_modules/src/d1/session.ts:82:24)
at async migrate (node_modules/src/d1/migrator.ts:47:3)
at async (server/plugins/migrations.ts:9:1)
at async Promise.all (index 0)
at async (node_modules/@nuxthub/core/dist/runtime/database/server/plugins/migrations.dev.js:15:5)
at async Promise.all (index 0)
at async (node_modules/@nuxthub/core/dist/runtime/ready.dev.js:5:3)`

Eddy401 · 2024-11-27T16:43:37Z

utlis/helpers.ts

+
+
+function compareToken(email, token) {
+    return generateSecureToken(email, token) === token


Suggested change

return generateSecureToken(email, token) === token

return generateSecureToken(email) === token

Eddy401 · 2024-11-27T16:46:08Z

utlis/helpers.ts

+
+export {
+    compareToken,
+    generateSecureToken,


Note: No need to export this function since its unused outside of this script.

Suggested change

generateSecureToken,

Eddy401 · 2024-11-27T17:22:05Z

modules/nuxtHubLanding/runtime/join-waitlist.post.ts

+
+export default defineEventHandler(async event => {
+    consola.info("User trying to signup for waitlist...")
+    const {emails} = useResend();


Question: Is there no import required?

Eddy401 · 2024-11-27T17:52:18Z

modules/nuxtHubLanding/runtime/join-waitlist.post.ts

+
+    consola.info("User joining waitlist...")
+
+    let entry = await useDrizzle().insert(tables.waitlist).values({


Thought: tables is not explicitly imported. This reduces readability.

Eddy401 · 2024-11-27T18:05:10Z

modules/nuxtHubLanding/index.ts

+        name: 'nuxtHubLanding',
+        configKey: "landing",


Thought: I think if this is supposed to be published as module a more descriptive name is required. How about evoize-waitlist?

Eddy401 · 2024-11-27T18:06:24Z

modules/nuxtHubLanding/index.ts

@@ -0,0 +1,76 @@
+import {addServerHandler, createResolver, defineNuxtModule, logger, extendPages} from 'nuxt/kit'


Suggestion: Add a prettifier to format this import syntax, disallow semicolons and disallow implicit imports.

Eddy401 · 2024-11-27T18:07:02Z

modules/nuxtHubLanding/index.ts

+    appName?: string
+    verifyEmail?: boolean
+    email?: string,
+    resendApiKey?: string,


Thought: All of those properties should be required.

lowbits added 9 commits September 25, 2024 14:23

docs(readme): Add more roadmap items

76d75a4

wip: Add email template

4e16bc8

wip: Add verify email flow

d1dd4ac

wip: Add verify email flow

aebaa4f

fix: remove token log

f8f3165

wip: Users needs to verify

ac772b9

fix: email is not encoded

3e7e9ca

docs(readme): Add double opt in feature getting started

c29c83d

docs(readme): Add secret key to documentation

d436456

feat: Add script to generate secret

d856196

lowbits added 13 commits November 22, 2024 08:55

debug: Add debug log to check available enviornment variables

6582695

chore: upgrade dependencies

260b935

refactor: Remove unnecessary env vars

0e58628

debug: try overwrite api key

ec6d19b

fix: wrong crypto import

91eb7b2

fix: Change hmac generatrion

0691ea0

fix: Change hmac generation

de8aeb5

fix: Change hmac generation

02f6433

debug: Add debug log to check available config

edc83de

fix: envrionment variables

144cf7b

fix: envrionment variables

08de478

chore: remove debug log

48d1df1

refactor: Add verify page dynamically based on need verify state

d35e096

elbbo reviewed Nov 27, 2024

View reviewed changes

Eddy401 suggested changes Nov 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/add double opt in#6

Feat/add double opt in#6
lowbits wants to merge 23 commits intomainfrom
feat/add-double-opt-in

lowbits commented Nov 21, 2024

Uh oh!

cloudflare-workers-and-pages bot commented Nov 21, 2024 •

edited

Loading

Uh oh!

what-the-diff bot commented Nov 22, 2024

Uh oh!

elbbo Nov 27, 2024

Uh oh!

elbbo Nov 27, 2024

Uh oh!

Eddy401 left a comment

Uh oh!

Eddy401 Nov 27, 2024

Uh oh!

Eddy401 Nov 27, 2024

Uh oh!

Eddy401 Nov 27, 2024

Uh oh!

Eddy401 Nov 27, 2024

Uh oh!

Eddy401 Nov 27, 2024

Uh oh!

Eddy401 Nov 27, 2024

Uh oh!

Eddy401 Nov 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		const config = useRuntimeConfig()


		if (config.landing.verifyEmail) {



		function compareToken(email, token) {
		return generateSecureToken(email, token) === token

	return generateSecureToken(email, token) === token
	return generateSecureToken(email) === token


		consola.info("User joining waitlist...")

		let entry = await useDrizzle().insert(tables.waitlist).values({

		@@ -0,0 +1,76 @@
		import {addServerHandler, createResolver, defineNuxtModule, logger, extendPages} from 'nuxt/kit'

Conversation

lowbits commented Nov 21, 2024

Uh oh!

cloudflare-workers-and-pages bot commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying nuxt-hub-landing with Cloudflare Pages

Uh oh!

what-the-diff bot commented Nov 22, 2024

PR Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eddy401 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cloudflare-workers-and-pages bot commented Nov 21, 2024 •

edited

Loading