Skip to content

Conversation

@jwnrt
Copy link

@jwnrt jwnrt commented Dec 3, 2024

This is required for Python 3.11 and 3.12 support without syntax warnings / errors.

Passed the fusesoc test suite (after apply this patch due to change of branch name):

Test URL patch (expand)
diff --git a/tests/capi2_cores/providers/url_simple.core b/tests/capi2_cores/providers/url_simple.core
index df0f42e..35dcc4c 100644
--- a/tests/capi2_cores/providers/url_simple.core
+++ b/tests/capi2_cores/providers/url_simple.core
@@ -9,4 +9,4 @@ name : ::url_simple:0
 provider:
   name       : url
   filetype   : simple
-  url        : https://github.com/olofk/fusesoc/raw/master/tests/test_provider/file.v
+  url        : https://github.com/olofk/fusesoc/raw/main/tests/test_provider/file.v
diff --git a/tests/capi2_cores/providers/url_simple_with_user_agent.core b/tests/capi2_cores/providers/url_simple_with_user_agent.core
index 24d1b30..08b0008 100644
--- a/tests/capi2_cores/providers/url_simple_with_user_agent.core
+++ b/tests/capi2_cores/providers/url_simple_with_user_agent.core
@@ -9,5 +9,5 @@ name : ::url_simple_with_user_agent:0
 provider:
   name       : url
   filetype   : simple
-  url        : https://github.com/olofk/fusesoc/raw/master/tests/test_provider/file.v
+  url        : https://github.com/olofk/fusesoc/raw/main/tests/test_provider/file.v
   user-agent : FuseSoC
diff --git a/tests/capi2_cores/providers/url_tar.core b/tests/capi2_cores/providers/url_tar.core
index d9634a8..eace9a2 100644
--- a/tests/capi2_cores/providers/url_tar.core
+++ b/tests/capi2_cores/providers/url_tar.core
@@ -9,4 +9,4 @@ name : ::url_tar:0
 provider:
   name       : url
   filetype   : tar
-  url        : https://github.com/olofk/fusesoc/raw/master/tests/test_provider/file.tar.gz
+  url        : https://github.com/olofk/fusesoc/raw/main/tests/test_provider/file.tar.gz
diff --git a/tests/capi2_cores/providers/url_zip.core b/tests/capi2_cores/providers/url_zip.core
index 5d10cd5..0590bba 100644
--- a/tests/capi2_cores/providers/url_zip.core
+++ b/tests/capi2_cores/providers/url_zip.core
@@ -9,4 +9,4 @@ name : ::url_zip:0
 provider:
   name       : url
   filetype   : zip
-  url        : https://github.com/olofk/fusesoc/raw/master/tests/test_provider/file.zip
+  url        : https://github.com/olofk/fusesoc/raw/main/tests/test_provider/file.zip

Copy link

@pamaury pamaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, if it passes the test suite then that's a good sign!

Copy link
Member

@HU90m HU90m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwnrt jwnrt merged commit 6c28bec into lowRISC:master Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants