Make MD element paragraphs <p> tags, tighter, with more spacing.#5
Open
jimbojw wants to merge 1 commit intolovvtide:masterfrom
Open
Make MD element paragraphs <p> tags, tighter, with more spacing.#5jimbojw wants to merge 1 commit intolovvtide:masterfrom
jimbojw wants to merge 1 commit intolovvtide:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small change has three effects:
<div>elements for paragraphs of text, it uses the semantic<p>tag.commentis truthy, the paragraphs'margin-bottomis increased from4pxto1em. By setting the margin inemunits, it will be proportional to the font size (14px).commentis truthy, the paragraphs'line-heightis decreased from21pxto1.4(unitless). By using a unitless value forline-height, it will be proportional to the font size (1.4 X 14px = ~19.6px).The result of these changes is that lines of text in paragraphs are closer together, while blank lines between paragraphs are wider. This groups related text more closely and makes paragraphs more clear.
However, because this change moves away from explicit pixel sizes, it may be controversial.