Reset previous selection when repeating calls to multi-select #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multi-select is called several times on the same 'select' HTML element (e.g. when this 'select' element is updated with fresh data from a database each time it is displayed), it is necessary to reset previous selections (if any) before processing current selected / unselected items, otherwise items that were in the class 'ms-selected' will remain in this class, and will therefore be (wrongly) displayed as selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multi-select is called several times on the same 'select' HTML
element (e.g. when this 'select' element is updated with fresh data
from a database each time it is displayed), it is necessary to
reset previous selections (if any) before processing current
selected / unselected items, otherwise items that were previously in the class
'ms-selected' will remain in this class, and will therefore be
(wrongly) displayed as selected.