Merged
Conversation
Owner
lord63
commented
Mar 16, 2026
lord63
commented
- migrate ci to github action;
- migrate to use uv;
- drop 2.x, support 3.10+
Replace .travis.yml with .github/workflows/ci.yml. Test matrix updated to Python 3.10-3.13.
Replace setup.py, setup.cfg, dev-requirements.txt, tox.ini, Makefile, and MANIFEST.in with pyproject.toml (hatchling backend) and uv.lock. Update GitHub Actions CI to use uv for dependency management.
- Remove `from __future__ import absolute_import` from all files - Remove `# -*- coding: utf-8 -*-` headers (unnecessary in Python 3) - Replace `io.open` with builtin `open` in source and tests - Update mock targets from `io.open` to `builtins.open` in tests - Use `super()` without arguments (Python 3 style)
Owner
Author
|
close #52 |
There was a problem hiding this comment.
Pull request overview
Modernizes the project’s packaging and CI to align with a Python 3.10+ baseline, replacing legacy tooling (Travis/tox/setup.py) with a pyproject.toml + uv workflow.
Changes:
- Migrates packaging to
pyproject.toml(hatchling) and introducesuv.lockfor dependency locking. - Replaces Travis CI with a GitHub Actions workflow using
uv. - Removes Python 2-era compatibility shims (
__future__,io.open, legacysuper(...)) across code/tests and drops tox/Makefile/dev requirements files.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Adds uv lockfile pinning runtime + dev dependencies for reproducible installs. |
pyproject.toml |
Defines project metadata, dependencies, scripts, build backend, and dev dependency group. |
.github/workflows/ci.yml |
New GitHub Actions CI running tests via uv across Python 3.10–3.13. |
tldr/parser.py |
Removes Py2 compatibility imports and switches to built-in open(). |
tldr/config.py |
Removes Py2 compatibility imports and switches to built-in open(). |
tldr/cli.py |
Switches JSON index read to built-in open() (removes io.open). |
tests/*.py |
Updates mocks to patch builtins.open, modernizes super() usage, removes old headers/imports. |
tox.ini, .travis.yml, setup.py, setup.cfg, dev-requirements.txt, Makefile, MANIFEST.in |
Removes legacy tooling/config now superseded by pyproject.toml + GitHub Actions + uv. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| version = "0.8.0" | ||
| description = "A python client for tldr: simplified and community-driven man pages." | ||
| readme = "README.rst" | ||
| license = "MIT" |
Comment on lines
+25
to
+29
| - name: Install dependencies | ||
| run: uv sync --python ${{ matrix.python-version }} | ||
|
|
||
| - name: Run tests | ||
| run: uv run pytest --cov-report term-missing --cov=tldr/ -vs tests/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.