Fixed error in CtHMM baum welch and maximum likelihood where tA /= pt should be 0 not NaN. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e 0 rather than NaN.
…times don't have transitions out of states.
|
I've been reading the comments you made and everything you suggested makes sense. Great work on debugging this yourself. Just know that the author of this repo is active only a few times a year so this will probably take a while to get approved. |
Author
|
No problem! I've just been working off my own repo, which I install directly from git with pip. I just figured, better to try and push changes upstream so others can benefit :) |
Collaborator
|
@lopatovsky, it looks like your thesis is done. Will you be able to give this project the time it deserves, or would it be better to share commit/release rights with other interested people? Or would you rather to keep control here, and suggest that others release forks under different names? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.