Production release: improve video error catching/logging, fix "failed to compile" console error, and docs updates#413
Merged
becky-gilbert merged 4 commits intomasterfrom Nov 22, 2024
Merged
Conversation
* comment out notes in JS code blocks (prevents build errors and improves syntax highlighting) * remove custom RTD theme and replace with template override with docs tabs * update project title * update python requirements * add docs JS file for opening external links in new tab and update file structure to match lookit-docs
* feat: add ajv compile error message in console * fix: remove capitalization errors in type specification
…ms (#402) * add video id to every event when using video-record mixin * add session video id to all events that session recording is in progress, and to specific set-up/stop events * update comments/docs about video/session recording events * add comment about error handling * add stopping flag and event logs for upload success/timeout/failed, improve errors for Sentry logging * add error catching and upload/timeout/error event logs for recording start/stop, improve errors for Sentry logging * if the study ends early via the confirmation dialog, then stop/upload any in-progress video recordings * switch completeUpload to promise chain instead of mixing with async/await, add upload part promises to chain to catch errors * switch record from async/await to promise then/catch; put createUpload in promise chain and catch/log all errors * only provide a stream time if recording is in progress, otherwise null
becky-gilbert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.