Add background blur for Logo / Menu Drawer icon on mobile view#83
Open
alvitali wants to merge 1 commit intoloof2736:mainfrom
Open
Add background blur for Logo / Menu Drawer icon on mobile view#83alvitali wants to merge 1 commit intoloof2736:mainfrom
alvitali wants to merge 1 commit intoloof2736:mainfrom
Conversation
Author
|
Can be tested with Edit: Just noticed my implementation is not yet optimized for the header in libraries / item pages. I'll leave this here in case you have any suggestions until I'll get around to improve this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was always annoyed by the menu drawer & logo not having the same blurred background as the header buttons and section tabs.
This adds CSS overrides for the .layout-mobile view to add the same rounded background with a blur filter that
.headerRightuses. Instead of adding.headerLeftto the declarations for those styles, I created a separate override underMobile fixesso that thebackground-blurdeclaration of .headerRight won't need to be unset for the desktop view.I've uploaded the exact rules I'm using on my Jellyfin instance to override the default / scyfin rules on alvitali@240ad65 where the changes are explained in detail with comments.
Setting the width of
tag. As long as the logo stays the same, this should work fine though. Heads up as I eyeballed the aspect-ratio for logo which does not correspond to the precise measurements of the default logo but I wanted to get this up here for another pair of eyes
.pageTitleWithDefaultLogowith theaspect-ratiodeclaration is rather fragile and could definitely be improved. However I didn't find a more robust way to set the width as jellyfin-web usesbackground-imageto set the logo instead of an