Added Chaos modpack #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoureaux
reviewed
May 9, 2025
index.json
Outdated
| "version": "2025-05-09-8a67d16", | ||
| "license": "GPL-3.0-or-later", | ||
| "type": "Modpack", | ||
| "url": "mods/Chaos-2025-05-09-8a67d16.json" |
Contributor
There was a problem hiding this comment.
What's the reason for copying the modpack instead of pointing directly to the json in the branch? (like Sextant and Aviation)
Contributor
Author
There was a problem hiding this comment.
I didn't know that was an option, I just used LTX as a template since that's what the ruleset was based on.
Contributor
There was a problem hiding this comment.
Let's avoid duplication then
Contributor
Author
There was a problem hiding this comment.
Does it matter that it's a .modpack rather than a .json?
Contributor
There was a problem hiding this comment.
Hm, the fc21 fcmp doesn't support the .modpack format anymore... maybe we should've tested it first? 😄
Contributor
Author
There was a problem hiding this comment.
No testing, only pushing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.