fix(#86): replace safety with pip-audit for dependency vulnerability scanning#97
Merged
fix(#86): replace safety with pip-audit for dependency vulnerability scanning#97
Conversation
…scanning - ci.yml: swap `safety scan` (advisory, || true) for `pip-audit` (hard gate) - pip-audit scans requirements/base.txt only; exits non-zero on any vuln - JSON report uploaded as pip-audit-report.json artifact - requirements/ci.txt: remove safety==3.7.0, add pip-audit>=2.7.0 - Baseline advisory run confirmed no current violations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
safetywithpip-auditas the dependency vulnerability scanner in CI. The oldsafety scanstep was advisory-only (|| true) and never blocked the pipeline.pip-auditruns as a hard gate — any known vulnerability inrequirements/base.txtfails the build.Baseline advisory run confirmed zero current violations before switching to enforcement.
Changes
.github/workflows/ci.yml: replacesafety scan --json > safety-report.json || truewithpip-audit -r requirements/base.txt --progress-spinner off -f json -o pip-audit-report.json(hard gate, no|| true).github/workflows/ci.yml: update job name, install step, and uploaded artifact namerequirements/ci.txt: removesafety==3.7.0, addpip-audit>=2.7.0Type
Testing
make docker-integrationpassed locally (required when touchingDockerfile,entrypoint.sh,docker-compose.yml, orpackages/parser-core/)Local baseline:
pip-audit -r requirements/base.txt --progress-spinner off→No known vulnerabilities foundChecklist
Downstream impact
bankstatements_core(exported class, function, or exception)