fix: read previous history snapshot when syncing manual tab group edits#85
Open
jafin wants to merge 1 commit intoloilo:mainfrom
Open
fix: read previous history snapshot when syncing manual tab group edits#85jafin wants to merge 1 commit intoloilo:mainfrom
jafin wants to merge 1 commit intoloilo:mainfrom
Conversation
useRefHistory stores the most recent (current) entry at index [0]. The lastUpdated watcher was reading [0] to find the "old" tab group state, which always matched the updated state — causing the early return to fire every time and preventing manual Chrome tab group renames/recolors from ever syncing back to the configuration. This mismatch also caused the superficial change handler to fail to find Chrome tab groups by their old title+color when the user later changed settings from the Options page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renames/recolors from ever syncing back to the extension configuration
May resolve #84