fix: use fileURLToPath for Windows-compatible __dirname and extract m…#83
Open
jafin wants to merge 1 commit intoloilo:mainfrom
Open
fix: use fileURLToPath for Windows-compatible __dirname and extract m…#83jafin wants to merge 1 commit intoloilo:mainfrom
jafin wants to merge 1 commit intoloilo:mainfrom
Conversation
…anifest build script
On Windows, `new URL('.', import.meta.url).pathname` returns a path with
a leading slash (e.g. `/D:/...`) which breaks `resolve()`. Using
`fileURLToPath()` produces a correct platform path. Also extracts the
inline manifest build command to a standalone script to avoid shell
quoting issues on Windows.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new URL('.', import.meta.url).pathnamewithfileURLToPath(new URL('.', import.meta.url))across pack.ts, vite.base.config.ts, and both rolldown background configs on Windows the.pathname approach returns /D:/... with a leading slash that breaks resolve()
node -e manifestbuild commands frompackage.jsoninto a standalonebuild-manifest.tsscript to avoid shell quoting issues on WindowsShould resolve #82