feat: allow users to set minimum tab threshold for auto-grouping#81
Draft
webdevnerdstuff wants to merge 2 commits intoloilo:mainfrom
Draft
feat: allow users to set minimum tab threshold for auto-grouping#81webdevnerdstuff wants to merge 2 commits intoloilo:mainfrom
webdevnerdstuff wants to merge 2 commits intoloilo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a user-configurable setting to define the minimum number of tabs required before the auto-grouping logic is triggered.
Changes:
Added a "Minimum Tab Threshold" option to the extension settings.
Updated the grouping logic to check against the user-defined threshold before creating or updating groups.
Ensured the default behavior remains consistent with existing functionality (e.g., threshold of 2).
Why:
This gives users more control over their workspace, preventing unnecessary group creation when only a few tabs are open from the same domain.
Testing & Compatibility:
Automated Tests: I haven't added Playwright tests yet as I’m still getting up to speed with the testing setup in this repo. I'm happy to tackle them with a bit of guidance or a reference to a similar test case if coverage is required for merge.
Manual Verification: I’ve verified the logic and UI persistence manually in Chrome. I haven't had a chance to test in other Chromium browsers (like Edge or Brave) yet.
Final Thoughts:
I’d love to get your thoughts on this, @loilo! I personally feel this adds significant value. I've used several tab managers, and the lack of a minimum threshold often leads to "group-bloat" for small tasks. This makes the auto-grouping feel much more intentional.