-
Notifications
You must be signed in to change notification settings - Fork 4
feat(*): step 5 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: step-5
Are you sure you want to change the base?
feat(*): step 5 #14
Changes from all commits
b89230e
64e86f9
25a10f0
b4b0bc5
117b2fd
5556829
03f25ad
4d99d30
cead24c
cc7b402
102df79
a74a35f
fd460bc
8c659e0
8c9229a
88567e7
3001597
c5cc8cc
3ca3873
e629447
9af6398
bbe43c8
a9afcc9
1f23dd3
24ff737
58f5c4b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ | |
| <surefire-plugin.version>2.22.0</surefire-plugin.version> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <quarkus.version>0.22.0</quarkus.version> | ||
| <quarkus.version>0.28.1</quarkus.version> | ||
|
||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
| </properties> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ | |
| <surefire-plugin.version>2.22.0</surefire-plugin.version> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <quarkus.version>0.26.1</quarkus.version> | ||
| <quarkus.version>0.28.1</quarkus.version> | ||
|
||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
| </properties> | ||
|
|
@@ -42,19 +42,22 @@ | |
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-smallrye-health</artifactId> | ||
| </dependency> | ||
| <!-- Step 5 dependencies --> | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wrong comment |
||
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-jdbc-postgresql</artifactId> | ||
| </dependency> | ||
| <!--/ Step 5 dependencies --> | ||
| <!-- Step 6 dependencies --> | ||
|
Comment on lines
+50
to
+51
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wrong comment |
||
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-smallrye-metrics</artifactId> | ||
| </dependency> | ||
| <!-- Step 5 dependencies --> | ||
| <!-- <dependency>--> | ||
| <!-- <groupId>io.quarkus</groupId>--> | ||
| <!-- <artifactId>quarkus-smallrye-reactive-messaging-amqp</artifactId>--> | ||
| <!-- </dependency>--> | ||
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-smallrye-reactive-messaging-amqp</artifactId> | ||
| </dependency> | ||
| <!--/ Step 5 dependencies --> | ||
| <!-- Step 6 dependencies --> | ||
| <!-- <dependency>--> | ||
|
|
@@ -74,6 +77,15 @@ | |
| <artifactId>quarkus-junit5</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <!--/ Step 6 dependencies --> | ||
|
|
||
|
|
||
| <!-- test dependencies--> | ||
| <dependency> | ||
| <groupId>io.rest-assured</groupId> | ||
| <artifactId>rest-assured</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
Comment on lines
+83
to
+88
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. duplicated |
||
| <dependency> | ||
| <groupId>io.rest-assured</groupId> | ||
| <artifactId>rest-assured</artifactId> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package fr.loicmathieu.bookmarkit; | ||
|
|
||
| import org.eclipse.microprofile.health.HealthCheck; | ||
| import org.eclipse.microprofile.health.HealthCheckResponse; | ||
| import org.eclipse.microprofile.health.Readiness; | ||
|
|
||
| @Readiness | ||
| public class AppHealthCheck implements HealthCheck { | ||
|
|
||
| @Override | ||
| public HealthCheckResponse call() { | ||
| return HealthCheckResponse.builder().name("bookmark").withData("is", "always").up().build(); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ | |
| <properties> | ||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
| <surefire-plugin.version>2.22.0</surefire-plugin.version> | ||
| <quarkus.version>0.26.1</quarkus.version> | ||
| <quarkus.version>0.28.1</quarkus.version> | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll change the quarkus version later from master ... |
||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comment, please don't do this if it previously works as the LOG usage is froma different step