Open
Conversation
This restores some behavior that was mistakenly removed in v3.0.0 (compared to v2.x) of this plugin. The previous behavior (v2.x) would log a *warning* when all matches failed. This patch brings this behavior back with some slight modifications: 1) It does not use structured logging (because we don't have a simple way to do this in log4j2 yet, as compared to our ruby logging style) 2) It logs at debug level. In 2.x, it logged at warning. 3) All parse failures are logged. In 2.x, only the last match-failure was logged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores some behavior that was mistakenly removed in v3.0.0
(compared to v2.x) of this plugin.
The previous behavior (v2.x) would log a warning when all matches
failed.
This patch brings this behavior back with some slight modifications:
way to do this in log4j2 yet, as compared to our ruby logging style)
was logged.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/