Add length-delimited option to encoder and decoder#48
Open
arman1371 wants to merge 5 commits intologstash-plugins:mainfrom
Open
Add length-delimited option to encoder and decoder#48arman1371 wants to merge 5 commits intologstash-plugins:mainfrom
arman1371 wants to merge 5 commits intologstash-plugins:mainfrom
Conversation
Contributor
|
@arman1371 thank you for the PR! We’ve created issue #58 to track the underline support for length-delimited messages, as this has been mentioned a couple of times. It would be great if your PR contained some test cases to ensure that the feature works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some databases (like clickhouse) just accept length-delimited messages and there isn't any option to send or receive length-delimited messages.
I added an option to support encoding and decoding of length-delimited messages.