Add more information to drop process to be used in callback function. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add to the return an object with the pressed keys (ctrl, alt or shift) pressed during the drag and drop.
Add the "from" argument (parent element of the draged element) to the onDrop callback.
Owner
|
No, the format is good, but could you clean this commit up some. You can use rebase to squash commits and keep them more focused. For example 0a0cdf4, e004b87, and bb8febf can all be combined into a single commit that reports the special keys being presseed. Also commits 77f2f29, 249508c, eeeea51, and 9ce3944 can be squashed into a single commit that adds the fromElement to the callback. |
Squashed commit: [249508c] Update README.md [9ce3944] Code FIX. Line 24: missing ')' and ';' (+1 squashed commits) Squashed commits: [77f2f29] Add fromEl argument to the callback function Add the "from" argument (parent element of the draged element) to the onDrop callback. (+1 squashed commits) Squashed commits: [181e2c0] Update README.md (+1 squashed commits) Squashed commits: [e004b87] Update README.md
Author
|
Well. I think that i did the squash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the keys used in the process of drag and drop.
Add the origin elment where the dragged element comes from.