Open
Conversation
Collaborator
|
Looks good to me. For testing, you might want to consider using tox. |
Contributor
Author
|
Happy for whatever set of CI/CD tools the maintainers would like to use. And my understanding is that Tox is completely compatible with Pytest tests as well. If its ok, I'd prefer to leave that config to the core maintainers, so that you can decide what platforms you'd like to support :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds simple tests as a base for more. Going under the
pytestframework.I've also added some dev tools which can be installed like:
I'd recommend using this as the base for getting some CI/CD setup. I like GitHub actions, but there are a few options. It'd be good to start getting code coverage reports at the same time. I recently got a nice setup for this over in another repo, if you'd like an example. Check out the config here:
https://github.com/AlecThomson/FixMS/blob/main/.github/workflows/test.yml