TID #007 Logging: Create a logger for both the app and the machine #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On initialization, it'll check if there exists an existing log file. If so, prepend filename with a timestamp, and then make a new file. On creation of a new logger, give them the File pointer to the file so they can write to the file with their prefix
On initialization, it'll check if there exists an existing log file. If so, prepend filename with a timestamp, and then make a new file. On creation of a new logger, give them the File pointer to the file so they can write to the file with their prefix
…to logging-dev
The logs from cat-app will be in the same file as cat-machine The exception errors will be printed pretty
A pointer to the open file was causing problems on others to use the file
Logging: Instead of having all the logs as 'error', changed some to be 'info' Label: Instead of printing some error messages to the screen, display them on the app
Logging: Instead of having all the logs as 'error', changed some to be 'info' Label: Instead of printing some error messages to the screen, display them on the app
Naming it logger doesn't sound right, I like golog/Golog better
errno, os, ConnectionError
loerac
commented
Aug 27, 2020
loerac
commented
Aug 27, 2020
loerac
commented
Aug 27, 2020
loerac
commented
Aug 27, 2020
loerac
commented
Aug 27, 2020
loerac
commented
Aug 27, 2020
loerac
added a commit
that referenced
this pull request
Aug 29, 2020
Once TID #3 is complete, update the "/feedNow" REST API to use the servo motors
embunny96
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis:
Add the ability to log for both the app and machine.
Description:
Both the app and machine should log their error/info messages. Both of them log to the same file under a specific identity, (app="cat-app", machine="cat-machine", rest-api="rest-api"). This will make it easier to find and save any issues that occur.
There is a rollover initialization that will take the existing log file and then add a timestamp to it before starting a new log file.
Test:
Logs being rolled over and creating a new log file
Logs being added
NOTE: Will add show more test when I get home