Skip to content

fix: add error handling for WiFi.scanNetworks() in /scan endpoint #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avineet4 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add error handling for WiFi.scanNetworks() in /scan endpoint #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/EasyWiFi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,17 @@ void EasyWiFi::startPortal() {
});

server.on("/scan", [this]() {
int networks = WiFi.scanNetworks();
Serial.printf("Scan complete: %d", networks);
int networks = WiFi.scanNetworks();

// Check for scan errors
if (networks < 0) {
Serial.printf("WiFi scan failed with error code: %d\n", networks);
server.send(500, "application/json",
"{\"error\":\"WiFi scan failed\",\"code\":" + String(networks) + "}");
return;
}

Serial.printf("Scan complete: %d networks found\n", networks);
String json = "[";

for (int i = 0; i < networks; i++) {
Expand All @@ -312,6 +321,7 @@ void EasyWiFi::startPortal() {
}
json += "]";

WiFi.scanDelete(); // Clean up scan results from memory
server.send(200, "application/json", json);
});

Expand Down