Skip to content

@5.4.1 - puppeteer@24.37.2, eslint@10 #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
localnerve merged 1 commit into from
Feb 11, 2026
Merged

@5.4.1 - puppeteer@24.37.2, eslint@10 #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions lib/async/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,21 +174,18 @@ class Notifier {
* @param {Number} timeout - timeout milliseconds to wait (max).
*/
add (outputFile, timeout) {
let failTimeout = timeout;
let timer;

if (!this.isStarted()) {
throw new Error("MUST call `start` before `add`");
}

if (!this._exists(outputFile)) {
// make sure we evaluate after the child process
failTimeout = parseInt(timeout, 10) + parseInt(this.padTimeout, 10);
let failTimeout = parseInt(timeout, 10) + parseInt(this.padTimeout, 10);
// Stagger and grow the failure timeout padding, add 1s every 10 processes
this.padTimeout += 100;

// setup a timeout handler to detect failure
timer = setTimeout(this.csFactory(done => {
let timer = setTimeout(this.csFactory(done => {
// if the output file has not already been removed
if (this._exists(outputFile)) {
pathExists(outputFile)
Expand Down
Loading