Html parser pull request #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h schema's dates. Only Microdata is available.
app/models/nokogiri_parser.rb
Outdated
Contributor
There was a problem hiding this comment.
File name should be based on the class name.
e.g: HtmlParser => html_parser.rb
app/models/html_parser.rb
Outdated
Contributor
There was a problem hiding this comment.
HtmlParser is not really a model but a library.
The lib directory is probably better.
A suitable model would be something like SchemaExtraction that would be used to store in the database the information extracted from a website.
Contributor
There was a problem hiding this comment.
Another think, HtmlParser doesn't seem like the right name. This is a schema.org parser.
…idator into html-parser
…idator into html-parser
Problem: SchemaObject problem duplicates validates_type_of errors
…idator into html-parser
…idator into html-parser
…idator into html-parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.