Skip to content

init: work around the mother of all race conditions #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmb merged 1 commit into from
Dec 5, 2025
Merged

init: work around the mother of all race conditions #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,19 @@ func minimalInit(sys syscaller, args []string) error {
fmt.Fprintf(stdio, "%s is not readable, execution might fail with %q\n", cmd.Path, err)
}

result := proc.Run()
result := proc.Start()
if result == nil {
// Work around a bug in virtio-console which doesn't deal well with concurrent
// access to a single serial port.
//
// It is crucial that we don't hold on to stdio, otherwise the runtime will
// opportunistically poll it, which causes writes to hang.
//
// See https://github.com/lmb/vimto/issues/29.
_ = stdio.Close()

result = proc.Wait()
}

if err := executeSimpleCommands(cmd.Teardown, cmd.Dir, cmd.Env); err != nil {
return fmt.Errorf("teardown: %w", err)
Expand Down