[Vulkan][Support] Add Sampler and SamplerComparison resource support #650
+1,112
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
s-perron
commented
Jan 13, 2026
s-perron
commented
- Add Sampler and SamplerComparison to ResourceKind in Pipeline.h.
- Implement Vulkan sampler creation and binding in lib/API/VK/Device.cpp.
- Add support for Samplers in YAML pipeline configuration.
- Add comprehensive tests for Texture2D sampling (Sample, SampleBias, SampleCmp).
- Add tests for sampler filter and address modes.
- Rename SRVToUAV tests for consistency.
Contributor
|
What's the status of this? |
Contributor
Author
|
I think the vulkan implementation is ready for review. I need to check that the testing is enough. |
s-perron
force-pushed
the
sampler
branch
2 times, most recently
from
8aa1fa0 to
841a343
Compare
- Add Sampler and SamplerComparison to ResourceKind in Pipeline.h. - Implement Vulkan sampler creation and binding in lib/API/VK/Device.cpp. - Add support for Samplers in YAML pipeline configuration. - Add comprehensive tests for Texture2D sampling (Sample, SampleBias, SampleCmp). - Add tests for sampler filter and address modes. - Rename SRVToUAV tests for consistency.
Contributor
Author
|
@luciechoi Please review as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.