Add multiple tests for semantics #648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds multiple tests around user & system semantics. This commit also enables the only graphic tests for Clang+Vulkan as it is now supported.
s-perron
reviewed
Jan 12, 2026
Contributor
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
Generally looks good. I think one test could be improved.
s-perron
reviewed
Jan 15, 2026
Contributor
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
I think the testing is good enough, but a test could be
Comment on lines
+6
to
+8
| Out[DTID.x * 3 + 0] = uint4(DTID.x, GID.x, GTID.x, GI); | ||
| Out[DTID.x * 3 + 1] = uint4(DTID.y, GID.y, GTID.y, 0); | ||
| Out[DTID.x * 3 + 2] = uint4(DTID.z, GID.z, GTID.z, 0); |
Contributor
There was a problem hiding this comment.
Why didn't you do:
uint4(DTID.x, GID.y, GTID.z, GI);
| #--- system_values.hlsl | ||
| RWStructuredBuffer<uint4> Out : register(u0); | ||
|
|
||
| [numthreads(2, 1, 1)] |
Contributor
There was a problem hiding this comment.
You might want to test all of the dimensions:
[numthreads(2, 2, 2)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds multiple tests around user & system semantics. This commit also enables the only graphic tests for Clang+Vulkan as it is now supported.