[Vulkan] Increase test coverage for push constants #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds multiple tests focusing on alternative types, offsets and nested structs.
First one had a bad offset (clang is broken when padding is required). Building this around so we can still test different types (padding is already covered by other tests). Also, fixed a badly written tests (superfluous static)
Contributor
Author
|
Only failure in the CI is a Wave related tests, not related to push constants. |
s-perron
reviewed
Jan 18, 2026
Contributor
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
Sorry. I had reviewed this earlier, but forgot to hit submit. The only real issue to be explicit about which layout you are using when compiling. The compilers have different default (as least for now).
Contributor
There was a problem hiding this comment.
@farzonl What is the current status of the row and col major attributes? Will they eventually be implemented in clang?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds multiple tests focusing on alternative types, offsets and nested structs.