Skip to content

Update wtfocus.js#5

Open
aaronbnb wants to merge 1 commit intolloydi:mainfrom
aaronbnb:main
Open

Update wtfocus.js#5
aaronbnb wants to merge 1 commit intolloydi:mainfrom
aaronbnb:main

Conversation

@aaronbnb
Copy link
Copy Markdown

@aaronbnb aaronbnb commented Mar 3, 2024

Iframe support for the overlay.

Select all iframes except those with the style display: none (only applies to inline CSS)
Create a script with the WTFocus code with escape/unescape characters and append the script to every iframe.
Enables the WTFocus selector to work within iframes

@jducrot
Copy link
Copy Markdown

jducrot commented Jan 21, 2025

@lloydi have you had a chance to consider this PR?

@lloydi
Copy link
Copy Markdown
Owner

lloydi commented Jan 22, 2025

@lloydi have you had a chance to consider this PR?

I completely missed that this was here. Sorry, @aaronbnb!

I get the request, but I suspect there is a more slick way to do this that doesn't involve a copy of all the code. I'll try to work out a solution that leaves me with only one lot of (highly inelegant) code to maintain instead of 2 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants