-
Notifications
You must be signed in to change notification settings - Fork 9
Enable Filtering From List of Profiles #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pearce8
merged 13 commits into
llnl:develop
from
michaelmckinsey1:feature-filter_profile
Jul 10, 2024
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ffdb4c8
Add new function
d3da41a
Change copy to deepcopy
michaelmckinsey1 a1725f4
Cast type for consistency
michaelmckinsey1 13f9207
Change _sync_profile_components to void
d82a365
Fix bug
8386e1d
Fix bug
michaelmckinsey1 a270ed9
Add unit tests
michaelmckinsey1 8b1f8c3
Fix bug
michaelmckinsey1 0237d5a
improve unit test
michaelmckinsey1 28e19fa
black
michaelmckinsey1 afdc317
Simplify logic
ff8fa35
Fix unit test
7b776bd
Black
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Copyright 2022 Lawrence Livermore National Security, LLC and other | ||
| # Thicket Project Developers. See the top-level LICENSE file for details. | ||
| # | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| from thicket import Thicket | ||
|
|
||
|
|
||
| def test_filter_profile(rajaperf_cali_1trial): | ||
| tk = Thicket.from_caliperreader(rajaperf_cali_1trial, disable_tqdm=True) | ||
|
|
||
| # Split profile list into two halves | ||
| rm_profs = tk.profile[len(tk.profile) // 2 :] | ||
| keep_profs = tk.profile[: len(tk.profile) // 2] | ||
|
|
||
| tk_filt = tk.filter_profile(keep_profs) | ||
|
|
||
| # Check each component that uses profiles | ||
| for component in [ | ||
| tk_filt.profile, | ||
| tk_filt.profile_mapping.keys(), | ||
| tk_filt.metadata.index, | ||
| tk_filt.dataframe.index.get_level_values("profile"), | ||
| ]: | ||
| assert all([prof not in component for prof in rm_profs]) | ||
| assert all([prof in component for prof in keep_profs]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.