-
Notifications
You must be signed in to change notification settings - Fork 13
Hosting data on pypi #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hosting data on pypi #107
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 64.13% 64.12% -0.01%
==========================================
Files 19 18 -1
Lines 7028 6973 -55
==========================================
- Hits 4507 4471 -36
+ Misses 2521 2502 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The modifications to enable hosting data directly on PyPI are well-implemented and will greatly simplify package distribution by removing the need for previous workarounds. The adjustments to MANIFEST.in, pyproject.toml, and setup.py ensure consistent inclusion of data files, and the removal of the redundant data_utils.py files and related tests is appropriate. |
The file limit on llnl-ssapy has been increased to 500 MiB (pypi/support#7292), meaning we are able to host all data files on PyPi and not have to create a workaround.
This MR made the following changes:
The data_utils.py files and related tests have been deleted.
The testpypi version is uploaded here: https://test.pypi.org/project/llnl-ssapy/
This version has been successfully imported and tested with the following code: