pyproject.toml instead of setup.py #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liam-DeVoe
reviewed
Sep 6, 2023
Collaborator
Liam-DeVoe
left a comment
Liam-DeVoe
left a comment
There was a problem hiding this comment.
Thanks! I'm in favor of this in principle (been slowly converting all of my projects to pyproject.toml).
Liam-DeVoe
requested changes
Sep 8, 2023
Collaborator
Liam-DeVoe
left a comment
Liam-DeVoe
left a comment
There was a problem hiding this comment.
It would be good if all the places the version is currently hardcoded in the codebase used from importlib import metadata; version = metadata.version(__package__) instead, to dynamically retrieve this value from pyproject.toml.
| "requests", | ||
| "scipy", | ||
| ] | ||
| scripts = {slider="slider.__main__:main"} |
Collaborator
There was a problem hiding this comment.
Is this correct? I believe this will cause a console_scripts entry point to be installed and add an executable named slider to the user's PATH. This is not what slider currently does: it's invoked with python -m slider, as on the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes
setup.pyin favour ofpyproject.toml, which follows the relatively new way of building Python packages specified by PEP-621.