This repository was archived by the owner on Dec 3, 2020. It is now read-only.
client now propagates event when remote is received#2
Open
hems wants to merge 1 commit intollevkin:masterfrom
hems:fix/server_connection_event
Open
client now propagates event when remote is received#2hems wants to merge 1 commit intollevkin:masterfrom hems:fix/server_connection_event
hems wants to merge 1 commit intollevkin:masterfrom
hems:fix/server_connection_event
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported on #1
server.on( "connection" ) was never fired when trying out the example.
My solution was to make Client an emitter and propagate the remote once it is received.
I'm obviously not sure if that was the place you intended to have this event happening, perhaps it shall come from the "proto" object you instantiated.
Let me know.