Fix bug that results in AttributeError - 'OccurrencePreview' object has no attribute 'object' #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #301 and #554
A couple of issues identified with the
OccurrencePreviewview - as follows:OccurrencePreviewclass means that theProcessFormView.getmethod is called first and foremost.ProcessFormView.getdoes not invoke theget_objectmethod meaning the object is never fetched from the database.modelattribute defined on the view class isOccurrence. Thepk_url_kwargattribute on the view class isoccurrence_id. The url pattern that this view class is bound to does not define anoccurrence_idpattern meaning theget_objectmethod call would fail if the default implementation ofget_objectwere usedAs a result of the above, when
get_context_datais called, theobjectattribute of the view has not been set, resulting in anAttributeError.The fix involves:
event_idfrom the url pattern to fetch the event from the dbPeriodclass to get occurrences for that point in timeThanks for the library. Please let me know if you'd like anything changed in the pull request