fix: handle asyncio.CancelledError in metrics try/except blocks#5336
Open
gyliu513 wants to merge 1 commit intollamastack:mainfrom
Open
fix: handle asyncio.CancelledError in metrics try/except blocks#5336gyliu513 wants to merge 1 commit intollamastack:mainfrom
gyliu513 wants to merge 1 commit intollamastack:mainfrom
Conversation
gyliu513
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
except asyncio.CancelledErrorhandlers beforeexcept Exceptionin all metrics-recording try/except blocks invector_io.pyandtool_runtime.py. This ensures disconnected/cancelled requests are still recorded as errors in metrics, matching the pattern already established inmetrics.pyThis is a follow up to addresses review feedback from #5201 (comment) for other metrics.
@leseb ^^
Test Plan