build: exclude milvus-lite on unsupported architectures#5335
Open
eoinfennessy wants to merge 4 commits intollamastack:mainfrom
Open
build: exclude milvus-lite on unsupported architectures#5335eoinfennessy wants to merge 4 commits intollamastack:mainfrom
eoinfennessy wants to merge 4 commits intollamastack:mainfrom
Conversation
Add platform markers to the milvus-lite dependency so it is only installed on architectures where binary wheels are available (x86_64, aarch64, arm64). This unblocks building and installing llama-stack on ppc64le and s390x where milvus-lite does not ship wheels. Signed-off-by: Eoin Fennessy <efenness@redhat.com>
eoinfennessy
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
mattf
approved these changes
Mar 27, 2026
Signed-off-by: Eoin Fennessy <efenness@redhat.com>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. @eoinfennessy please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
milvus-litedependency so it is only installed on architectures where binary wheels are available (x86_64,aarch64,arm64)milvus-liteis a binary-only package with no sdist, and only ships wheels for these four platforms (macOS x86_64, macOS arm64, manylinux aarch64, manylinux x86_64)ppc64leands390xDepends on #5334 (bumps
pymilvusto>=2.6.2wheremilvus-liteis an optional extra rather than a hard dependency)