Skip to content

refactor: split large test and source files into focused modules #5299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skamenan7 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: split large test and source files into focused modules #5299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
004650f
refactor(tests): split test_openai_mixin.py by concern into 3 files
skamenan7 Mar 25, 2026
879f7bf
refactor(tests): split test_openai_responses.py unit tests by feature…
skamenan7 Mar 25, 2026
ea9c945
refactor(scoring): split ifeval_utils.py and extract WORD_LIST data
skamenan7 Mar 25, 2026
da84966
refactor(scoring): apply upstream get_langid docstring to ifeval_supp…
skamenan7 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ def _looks_like_existing_test_path(arg: object) -> bool:
# Import plugins dynamically
if running_unit:
config.pluginmanager.import_plugin("tests.unit.fixtures")
# Load shared fixtures from openai_responses test file (used by conversations tests)
config.pluginmanager.import_plugin("tests.unit.providers.responses.builtin.test_openai_responses")

if running_integration:
config.pluginmanager.import_plugin("tests.integration.fixtures.common")
11 changes: 10 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,16 @@ convention = "google"
"benchmarking/**/*.py" = ["D101"] # Ignore docstring rules for benchmarking scripts
"client-sdks/**/*.py" = ["D101"] # Ignore docstring rules for client SDKs
"scripts/**/*.py" = ["D101"] # Ignore docstring rules for scripts
"src/llama_stack/providers/inline/scoring/basic/utils/ifeval_utils.py" = [
"src/llama_stack/providers/inline/scoring/basic/utils/ifeval_support.py" = [
"RUF001",
]
"src/llama_stack/providers/inline/scoring/basic/utils/ifeval_checkers_core.py" = [
"RUF001",
]
"src/llama_stack/providers/inline/scoring/basic/utils/ifeval_checkers_format.py" = [
"RUF001",
]
"src/llama_stack/providers/inline/scoring/basic/utils/ifeval_word_list.py" = [
"RUF001",
]
"src/llama_stack/providers/inline/scoring/basic/scoring_fn/fn_defs/regex_parser_multiple_choice_answer.py" = [
Expand Down
4 changes: 1 addition & 3 deletions scripts/check_file_size.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
GRANDFATHERED_FILES = {
"src/llama_stack/providers/inline/responses/builtin/responses/openai_responses.py",
"src/llama_stack/providers/inline/responses/builtin/responses/streaming.py",
"src/llama_stack/providers/inline/scoring/basic/utils/ifeval_utils.py",
"src/llama_stack/providers/inline/scoring/basic/utils/ifeval_word_list.py", # pure data file
"src/llama_stack/providers/utils/memory/openai_vector_store_mixin.py",
"src/llama_stack/providers/registry/vector_io.py",
"src/llama_stack/testing/api_recorder.py",
Expand All @@ -37,8 +37,6 @@
"tests/integration/vector_io/test_openai_vector_stores.py",
"tests/integration/responses/test_openai_responses.py",
"tests/integration/responses/test_tool_responses.py",
"tests/unit/providers/responses/builtin/test_openai_responses.py",
"tests/unit/providers/utils/inference/test_openai_mixin.py",
}


Expand Down
Loading
Loading