Skip to content

fix: make tool call assertions flexible to prevent CI flakes #5295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamemilio wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −18
Open

fix: make tool call assertions flexible to prevent CI flakes #5295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fd2730
fix: make tool call assertions flexible to prevent CI flakes
iamemilio Mar 25, 2026
e382254
Merge branch 'main' into fix/flexible-tool-call-assertions
leseb Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions tests/integration/responses/test_tool_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,10 +462,11 @@ def test_response_non_streaming_custom_tool(responses_client, text_model_id, cas
tools=case.tools,
stream=False,
)
assert len(response.output) == 1
assert response.output[0].type == "function_call"
assert response.output[0].status == "completed"
assert response.output[0].name == "get_weather"
assert len(response.output) >= 1
function_calls = [o for o in response.output if o.type == "function_call"]
assert len(function_calls) >= 1
assert function_calls[0].status == "completed"
assert function_calls[0].name == "get_weather"


@pytest.mark.parametrize("case", custom_tool_test_cases)
Expand Down Expand Up @@ -582,16 +583,16 @@ def test_function_call_output_list_text(responses_client, text_model_id):
tools=tools,
stream=False,
)
assert len(response.output) == 1
assert response.output[0].type == "function_call"
call_id = response.output[0].call_id
function_calls = [o for o in response.output if o.type == "function_call"]
assert len(function_calls) >= 1

inputs = [
{
"type": "function_call_output",
"call_id": call_id,
"call_id": fc.call_id,
"output": [{"type": "input_text", "text": "It is sunny and 22 degrees Celsius in Paris."}],
},
}
for fc in function_calls
]
response2 = responses_client.responses.create(
model=text_model_id,
Expand All @@ -600,8 +601,8 @@ def test_function_call_output_list_text(responses_client, text_model_id):
stream=False,
previous_response_id=response.id,
)
assert len(response2.output) == 1
assert response2.output[0].type == "message"
messages = [o for o in response2.output if o.type == "message"]
assert len(messages) >= 1
assert response2.output_text


Expand Down Expand Up @@ -631,19 +632,19 @@ def test_function_call_output_list_text_multi_block(responses_client, text_model
tools=tools,
stream=False,
)
assert len(response.output) == 1
assert response.output[0].type == "function_call"
call_id = response.output[0].call_id
function_calls = [o for o in response.output if o.type == "function_call"]
assert len(function_calls) >= 1

inputs = [
{
"type": "function_call_output",
"call_id": call_id,
"call_id": fc.call_id,
"output": [
{"type": "input_text", "text": "Current conditions: overcast skies."},
{"type": "input_text", "text": "Temperature: 15 degrees Celsius."},
],
},
}
for fc in function_calls
]
response2 = responses_client.responses.create(
model=text_model_id,
Expand All @@ -652,8 +653,8 @@ def test_function_call_output_list_text_multi_block(responses_client, text_model
stream=False,
previous_response_id=response.id,
)
assert len(response2.output) == 1
assert response2.output[0].type == "message"
messages = [o for o in response2.output if o.type == "message"]
assert len(messages) >= 1
assert response2.output_text


Expand Down
Loading