feat: update openai tests to work with both clients#2442
Merged
hardikjshah merged 1 commit intollamastack:mainfrom Jun 12, 2025
Merged
feat: update openai tests to work with both clients#2442hardikjshah merged 1 commit intollamastack:mainfrom
hardikjshah merged 1 commit intollamastack:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
hardikjshah
requested review from
ashwinb,
bbrowning,
ehhuang,
leseb,
raghotham,
reluctantfuturist,
terrytangyuan and
yanxi0830
as code owners
franciscojavierarceo
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llamastack/llama-stack-client-python#238 updated llama-stack-client to also support Open AI endpoints for embeddings, files, vector-stores. This updates the test to test all configs -- openai sdk, llama stack sdk and library-as-client.