Conversation
facebook-github-bot
added
the
CLA Signed
yanxi0830
requested review from
SLR722,
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
raghotham,
sixianyi0721,
terrytangyuan and
vladimirivic
as code owners
booxter
suggested changes
Mar 12, 2025
ashwinb
reviewed
Mar 13, 2025
|
|
||
|
|
||
| @pytest.fixture | ||
| def test_dataset(llama_stack_client): |
Contributor
There was a problem hiding this comment.
- can we call this something not with a
test_prefix because that is how tests are typically marked. maybedataset_for_test? - also we call
unregister()manually with the "test_dataset" argument butregister_dataset()is not passed that argument?
Contributor
Author
There was a problem hiding this comment.
renamed fixture & register dataset with explicit id
ashwinb
reviewed
Mar 13, 2025
ashwinb
approved these changes
Mar 13, 2025
booxter
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan