Conversation
facebook-github-bot
added
the
CLA Signed
ehhuang
added a commit
to llamastack/llama-stack-client-python
that referenced
this pull request
Mar 6, 2025
# Summary: This PR simplifies the Agent SDK (related to #160) Before ``` agent_config = AgentConfig(models, instructions, toolgroups, client_tools, ...) agent = Agent(client, agent_config, client_tools) ``` Now just: ``` agent = Agent(client, model, instructions, tools, ...) ``` See https://github.com/meta-llama/llama-stack-apps/pull/200/files for example. Will update all examples and docs once this PR looks good. # Test Plan: Run test_agents.py with llamastack/llama-stack#1402
Summary: Test Plan:
ehhuang
added a commit
to llamastack/llama-stack-client-python
that referenced
this pull request
Mar 6, 2025
Summary: otherwise errors on L127 Test Plan: py.test -v -s --nbval-lax ./docs/getting_started.ipynb with llamastack/llama-stack#1402
ehhuang
requested review from
SLR722,
ashwinb,
dineshyv,
dltn,
hardikjshah,
raghotham,
sixianyi0721,
terrytangyuan,
vladimirivic and
yanxi0830
as code owners
ashwinb
reviewed
Mar 6, 2025
| **common_params, | ||
| ) | ||
| Server__AgentConfig(**agent_config) | ||
| Server__AgentConfig(**common_params) |
Contributor
There was a problem hiding this comment.
what is this crazy looking expression which is not getting assigned to anything
Contributor
Author
There was a problem hiding this comment.
haha just asserting that it works without error. I'll deprecate tool_choice and remove these test.
ashwinb
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
new Agent SDK API is added in llamastack/llama-stack-client-python#178
Update docs and test to reflect this.
Closes #1365
Test Plan: