Conversation
Summary: This bug is surfaced by using the http LS client. The issue is that non-scalar values in 'GET' method are `body` params in fastAPI, but our spec generation script doesn't respect that. We fix by just making them POST method instead. Test Plan: Test API call with newly sync'd client (llamastack/llama-stack-client-python#149)
facebook-github-bot
added
the
CLA Signed
ehhuang
commented
Feb 20, 2025
ehhuang
commented
Feb 20, 2025
ehhuang
requested review from
ashwinb,
dineshyv,
dltn,
hardikjshah,
raghotham,
sixianyi0721,
terrytangyuan,
vladimirivic and
yanxi0830
as code owners
yanxi0830
approved these changes
Feb 20, 2025
ashwinb
reviewed
Feb 20, 2025
|
|
||
| @webmethod(route="/telemetry/spans/{span_id:path}/tree", method="GET") | ||
| @webmethod(route="/telemetry/spans/{span_id:path}/tree", method="POST") | ||
| async def get_span_tree( |
Contributor
There was a problem hiding this comment.
nit: can we rename this query_span_tree? even the response type is QuerySpanTreeResponse ... having a get_ method be called POST is causing me a bit of dissonance. "query_" makes it slightly more palatable.
Contributor
Author
There was a problem hiding this comment.
Sg. Let me do the renaming in a followup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This bug is surfaced by using the http LS client. The issue is that non-scalar values in 'GET' method are
bodyparams in fastAPI, but our spec generation script doesn't respect that. We fix by just making them POST method instead.Test Plan:
Test API call with newly sync'd client (llamastack/llama-stack-client-python#149)