Closed
Conversation
raghotham
requested changes
Feb 20, 2025
Member
raghotham
left a comment
There was a problem hiding this comment.
we should probably allow for both env vars and deprecate the older one - this is not a backward compatible change
Contributor
|
this code is auto-generated @raghotham |
Contributor
|
unless we do more work, you aren't going to get back-compat. I don't think this one is worth it at all. |
Contributor
Author
|
I could extend the sync script and add a manual modification of lines like |
Member
|
Not needed. Overwritten by #157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We are updating ENV var names to follow shorter naming pattern, the env vars will be prefixed by LLAMA_STACK instead of LLAMA_STACK_CLIENT which was previously auto-generated by Stainless by reading the project name field in the spec, but Stainless added a new feature where we can override this prefix.
Test Plan