Sync updates from stainless branch: ehhuang/dev#126
Closed
Conversation
ehhuang
requested review from
ashwinb,
dineshyv,
dltn,
hardikjshah,
raghotham,
vladimirivic and
yanxi0830
as code owners
vladimirivic
reviewed
Feb 6, 2025
| def qs(self) -> Querystring: | ||
| return Querystring(array_format="comma") | ||
|
|
||
| @property |
Contributor
There was a problem hiding this comment.
@ehhuang how did you get these changes, this was not supposed to be here yet because adding api_key Stainless config was only in a dev branch but not in main. It's ok if we leave this here though we will just need to remove api key changes from the sync_stainless script.
vladimirivic
reviewed
Feb 6, 2025
| This automatically infers the `api_key` argument from the `LLAMA_STACK_API_KEY` environment variable if it is not provided. | ||
| """ | ||
| if api_key is None: | ||
| api_key = os.environ.get("LLAMA_STACK_API_KEY") |
Contributor
There was a problem hiding this comment.
We should name this LLAMA_STACK_CLIENT_API_KEY
so it has the same prefix as LLAMA_STACK_CLIENT_BASE_URL. The env name is defined in the Stainless config.
Contributor
Author
|
closing in favor of #129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sync stainless SDK
Test Plan
Sources
Please link relevant resources if necessary.
Before submitting
Pull Request section?