Refactor: Extract common worker logic to eliminate ~500 lines of duplication #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created shared/worker-utils.ts with createUnifiedWorkerHandler factory - Extracted logWorkerMetrics function to shared utility - Extracted HandlerResult interface to shared utility - Updated SR, SW, LR, and LW workers to use shared utility - Reduced code duplication by ~500 lines - Added performance metrics to LW worker (previously missing) Co-authored-by: llama90 <6668548+llama90@users.noreply.github.com>
- Remove HandlerResult | void union type from WorkerConfig - All handlers now required to return HandlerResult - Updated build handler to return HandlerResult with syncResponseMs - Removed fragile type check for handlerResult (always defined now) - Improved type consistency across all handlers Co-authored-by: llama90 <6668548+llama90@users.noreply.github.com>
- Added detailed JSDoc explaining the function's purpose - Documented use cases (E2E latency, queue wait time, etc.) - Added parameter documentation - Improved code maintainability and discoverability Co-authored-by: llama90 <6668548+llama90@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on mockup logic for long-read short-write commands
Refactor: Extract common worker logic to eliminate ~500 lines of duplication
Jan 13, 2026
Contributor
|
@copilot Please refactor this code into smaller functions that are easier to test. |
Split createUnifiedWorkerHandler into focused, single-responsibility functions: - parseWorkerMessage: Extracts message parsing logic - createMessageLogger: Handles logger creation with correlation context - getCommandHandler: Validates and retrieves command handlers - calculatePerformanceMetrics: Computes timing metrics - processRecord: Orchestrates single record processing Benefits: - Each function has a clear, testable purpose - Easier to unit test individual components - Maintains exact same behavior and async boundaries - No changes to external function signatures - More maintainable and easier to understand Co-authored-by: llama90 <6668548+llama90@users.noreply.github.com>
Contributor
Author
I've refactored the code into smaller, focused functions. The main handler is now broken down into: New functions (all with single responsibilities):
Result:
The refactor maintains pragmatism - each extracted function has a clear purpose without over-abstracting. Commit: 32b6978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/shared/worker-utils.tswith common handler logiclogWorkerMetricsfunction to shared utilityHandlerResultinterface to shared typescreateUnifiedWorkerHandlerfactory function that accepts configuration✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.