Add delays to avoid corrupting packages.#185
Open
Magic-Doufu wants to merge 1 commit intoljean:masterfrom
Open
Add delays to avoid corrupting packages.#185Magic-Doufu wants to merge 1 commit intoljean:masterfrom
Magic-Doufu wants to merge 1 commit intoljean:masterfrom
Conversation
|
|
||
| # Read rest of the request | ||
| while True: | ||
| # Add delays to avoid corrupting packages. (For use with FT232-RS485 device.) |
There was a problem hiding this comment.
"For use with FT232-RS485 device"???
But it's sitting under a while True and will affect every modbus_rtu device.
This will halt all execution for every modbus-rtu device prior to reading the rest of a request, a completely unessesary performance impact for many applications which do not warrant it.
I've had projects pushing near 500 requests per second, and i wouldn't be suprised if others are pushing higher, even if just in bench tests a 0.001s delay is massive in that regard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add delays to solve corruption pack issue. (CH341 working well, but ft232 with vcp driver always corrupting.)